Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use with instead of assert in rollup.mjs #2326

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

negezor
Copy link
Contributor

@negezor negezor commented Aug 4, 2024

Fixes a build error on newer versions of Node.js. Import attributes by specification should use with keyword instead of assert and it's already on stage 3, so proposal is accepted. https://github.com/tc39/proposal-import-attributes

This is also mentioned in TypeScript 5.3 https://devblogs.microsoft.com/typescript/announcing-typescript-5-3/#import-attributes

Scope: 3 of 4 workspace projects
packages/router build$ rimraf dist && rollup -c rollup.config.mjs
│ [!] SyntaxError: Unexpected identifier 'assert'

Copy link

netlify bot commented Aug 4, 2024

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 4006a6c
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/66afb457438b640008785ad9

@posva posva changed the title fix(build): use with instead of assert chore: use with instead of assert in rollup.mjs Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (7422b15) to head (4006a6c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2326   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          26       26           
  Lines        6013     6013           
  Branches      819      819           
=======================================
  Hits         5852     5852           
  Misses        159      159           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit 7d1db18 into vuejs:main Aug 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants