Fix #2249

vuejs · Sep 6, 2020 · 8a59a06 · 8a59a06
1 parent c2512c2
commit 8a59a06
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ### 0.27.2
 
+- Add a config `vetur.validation.props` to toggle props validation. Default to false. #2249.
 - 🙌 Add HTML folding. Thanks to contribution from [@yoyo930021](https://github.com/yoyo930021). #2234 and #2244.
 - 🙌 Fix array get error type in v-for. Thanks to contribution from [@yoyo930021](https://github.com/yoyo930021). #1790 and #2248.
 - 🙌 Fix corner case and add v-model support when prop validation. Thanks to contribution from [@yoyo930021](https://github.com/yoyo930021). #2241.

diff --git a/package.json b/package.json
@@ -246,6 +246,11 @@
           "default": true,
           "description": "Validate vue-html in <template> using eslint-plugin-vue"
         },
+        "vetur.validation.templateProps": {
+          "type": "boolean",
+          "default": false,
+          "description": "Validate props usage in <template> region. Show error/warning for not passing declared props to child components."
+        },
         "vetur.validation.interpolation": {
           "type": "boolean",
           "default": true,

diff --git a/server/src/config.ts b/server/src/config.ts
@@ -30,6 +30,7 @@ export interface VLSConfig {
     };
     validation: {
       template: boolean;
+      templateProps: boolean;
       interpolation: boolean;
       style: boolean;
       script: boolean;
@@ -79,6 +80,7 @@ export function getDefaultVLSConfig(): VLSFullConfig {
       useWorkspaceDependencies: false,
       validation: {
         template: true,
+        templateProps: false,
         interpolation: true,
         style: true,
         script: true

diff --git a/server/src/modes/template/htmlMode.ts b/server/src/modes/template/htmlMode.ts
@@ -63,9 +63,11 @@ export class HTMLMode implements LanguageMode {
   doValidation(document: TextDocument) {
     const diagnostics = [];
 
-    const info = this.vueInfoService ? this.vueInfoService.getInfo(document) : undefined;
-    if (info && info.componentInfo.childComponents) {
-      diagnostics.push(...doPropValidation(document, this.vueDocuments.refreshAndGet(document), info));
+    if (this.config.vetur.validation.templateProps) {
+      const info = this.vueInfoService ? this.vueInfoService.getInfo(document) : undefined;
+      if (info && info.componentInfo.childComponents) {
+        diagnostics.push(...doPropValidation(document, this.vueDocuments.refreshAndGet(document), info));
+      }
     }
 
     if (this.config.vetur.validation.template) {