Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vetur 0.26.x is no longer applying changes for eslint / prettier #2126

Closed
3 tasks done
geoidesic opened this issue Aug 7, 2020 · 1 comment
Closed
3 tasks done

Vetur 0.26.x is no longer applying changes for eslint / prettier #2126

geoidesic opened this issue Aug 7, 2020 · 1 comment

Comments

@geoidesic
Copy link

geoidesic commented Aug 7, 2020

  • I have searched through existing issues
  • I have read through docs
  • I have read FAQ

Info

  • Platform: macOS
  • Vetur version: 0.26.1
  • VS Code version: 1.47.3

Problem

Yesterday Vetur was working fine, it would fix my VueJS SFC files on save. I've made no changes to VsCode settings. Today Vetur no longer fixes my code. I've had to roll back to v0.25.0 to get it to work again.

Reproducible Case

The steps are simple in my case: open any SFC VueJS file, write some non-eslint-compliant code and hit save. It should correct the code to eslint standard.

Here is my settings.json:

{
  // "editor.formatOnPaste": true,
  "editor.formatOnSave": true,
  "editor.codeActionsOnSave": {
    "source.fixAll": true
  },
  "jest.pathToJest": "yarn test:unit",
  "jest.showCoverageOnLoad": true,
  "php-cs-fixer.executablePath": "${extensionPath}/php-cs-fixer.phar",
  "php-cs-fixer.lastDownload": 1596197060819,
  "php-cs-fixer.autoFixBySemicolon": true,
  "php-cs-fixer.onsave": true,
  "stylusSupremacy.insertBraces": false,
  "stylusSupremacy.insertSemicolons": false,
  "vetur.format.defaultFormatter.html": "prettyhtml",
  "vetur.format.defaultFormatter.js": "prettier-eslint",
  "vetur.format.scriptInitialIndent": true,
  "vetur.format.styleInitialIndent": true,
  "window.zoomLevel": 0,
  "diffEditor.ignoreTrimWhitespace": true,
  "[vue]": {
    "editor.defaultFormatter": "octref.vetur"
  },
  "[javascript]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "editor.tabSize": 2,
  "editor.detectIndentation": false,
  "editor.fontFamily": "Fira Code",
  //"Monaco, Fira Code, Menlo, 'Courier New', monospace",
  "editor.fontLigatures": true
}

Seems to relate to #2116, (which the author closed in impatience).

@geoidesic geoidesic changed the title After last update Vetur is no longer applying changes for eslint / prettier Vetur 0.26.x is no longer applying changes for eslint / prettier Aug 7, 2020
@octref
Copy link
Member

octref commented Aug 7, 2020

Duplicate of #2125.

@octref octref closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants