Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting not working with version 0.26.0 #2116

Closed
csicky opened this issue Aug 5, 2020 · 9 comments · Fixed by #2117
Closed

Formatting not working with version 0.26.0 #2116

csicky opened this issue Aug 5, 2020 · 9 comments · Fixed by #2117

Comments

@csicky
Copy link

csicky commented Aug 5, 2020

Problem

After update to 0.26.0 format does not work anymore. I have reverted using vsix package to 0.25.0 and the format works again. I have a lot of extensions, might be a conflict. Please let me know if you need to export some config and how to do it. With so many settings and extensions configs I can't tell why it was working and why it is not with latest version. Might be Prettier or eslint not working well with latest version of Vetur.

image

@yoyo930021
Copy link
Member

yoyo930021 commented Aug 5, 2020

Please provide your vetur formatting config.
https://vuejs.github.io/vetur/formatting.html#formatters

You can see CHANGELOG and commit.

@csicky
Copy link
Author

csicky commented Aug 5, 2020

THX for help, one more question please :)

What formatting config to give to vetur to make it work like is in version 0.25.0? I would have preferred that this is migrated automatically and I don't have to come here asking questions as I don't have that much time, but now that we are here, the page you linked doesn't tell me which one to choose.

Now looking there and I have formatters selected. For some reason 0.26.0 doesn't pick them up?

image

@yoyo930021
Copy link
Member

yoyo930021 commented Aug 5, 2020

I need to know what are you used for formatting.

@yoyo930021
Copy link
Member

yoyo930021 commented Aug 5, 2020

I guess it's a bug for prettier-eslint and vetur.
Short term:

  1. install prettier-eslint in your project, and notice add dependency on core-js@^3.6.5 prettier/prettier-eslint#359.
  2. Not use prettier-eslint.

@octref I think we need to downgrade prettier-eslint version.
You upgrade in 56df0f3.

@csicky
Copy link
Author

csicky commented Aug 5, 2020

So, for now I can keep using 0.25.0. Thank you for your help.

yoyo930021 added a commit to yoyo930021/vuter that referenced this issue Aug 5, 2020
@yoyo930021
Copy link
Member

The v0.26.1 is release.

@csicky
Copy link
Author

csicky commented Aug 7, 2020

I am sorry to report that the problem was not resolved. I have upgraded to 0.26.1 and the format is not working. If you need some debugging info, please let me know what to do to export it. It is very well possible that I have some old config which might conflict. In the meantime I go back to 0.25.0 so I can work.

@yoyo930021
Copy link
Member

I am sorry to report that the problem was not resolved. I have upgraded to 0.26.1 and the format is not working. If you need some debugging info, please let me know what to do to export it. It is very well possible that I have some old config which might conflict. In the meantime I go back to 0.25.0 so I can work.

Please provide reproducible case.
https://github.com/vuejs/vetur/blob/master/.github/NO_REPRO_CASE.md

@csicky
Copy link
Author

csicky commented Aug 7, 2020

It seems I will stay on 0.25.0 as I don't have time to do that repro thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants