-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting code actions from ''Vetur', 'Eslint'' takes too long! #2150
Comments
I meet the same issue on Win as well. Downgrading to 0.25.0 temporarily solve problem |
I have the same problem, too |
Not sure if this is not another extension I have but just throwing it out there - does anybody's code sometimes get mangled (eg. one line gets duplicated) after Vetur + Eslint code actions finish after a long time? |
@3nuc This happens for me sometimes, when I cancel the long running action. Maybe eslint/prettier related? |
I'm having the same issue, any solutions/workarounds? :) Edit: The only thing that works is exiting VSCode and reopen the project. How to provide debug info? Edit 2: This is on Linux using the latest VSCode. |
|
For me, yes. When I have both vetur and eslint enabled I am getting the same message as @daolanfler
and it hangs for 5 to 7 seconds. Disabling eslint doesn't fix it, Also, one important thing I have to add here is that the mentioned message is shown only once when I try to save .vue file with lint problems. After the message disappears, saving the same file or any other .vue file with lint problems is immediate.
Nope. |
I've had this issue for quite a long time. I'm using TS in a Quasar project and after a fresh open of VS Code and starting the dev server it works fine for a while. After about a half hour of use, it starts taking a very long time to finish linting lines before save. When saving, if the before-save linting didn't quite finish, I get the code actions pop up for up to half a minute. On a pretty powerful computer, so that shouldn't be the issue |
I'm not sure, but it seems to be related to this issue microsoft/vscode#101555. My hunch is that incomplete save participants are hanging around in a process which ends up slowing everything down. I don't have any way to prove or reproduce, but they both seem to happen around the same time. |
@octref Just to confirm here the setting doesn't fix the 'Getting code actions from..' hang. |
Another observation I found that the issue occurs if try to format or save in a specific workspace. The extensions works perfect if I change the project workspace. |
Temporary fix I use: |
This doesn't work for me on mac :/ Edit: Instead vscode is taking 100% CPU after restarting extension host. |
I'll make a setting that disables |
Waiting up.. |
How about disabling eslint code action from eslint in Vue files? Keeping only vetur actions. {
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
},
"[vue]": {
"editor.codeActionsOnSave": {
"source.fixAll.eslint": false
}
},
} Would that help? I tried on my local, will report soon. |
It seems to work and keep both extensions at bay. |
Caveat: template autofix will not be proceeded. |
@elevatebart So in your case it's ESLint hanging up, not Vetur, is that correct? |
It's the two waiting for each other I believe. |
May be this isn't the expected solution but I managed to fix it by resetting all the stuff.
and done ! Above steps fixed Vue Formatting for me,. (It does not get stuck on loading now).. |
@imtiyazs This doesn't fix the issue, I have reinstalled and cleaned my settings a few times already. The issues can be triggered when dealing with multiple formatting issues. Downgrading does make it trigger less, but still it seems to happen because some extensions seem to waiting for each other. |
Um.. Pretty hard to find exact scenario. I faced this issue in one of the repo. After switching the repo, the extensions worked perfectly (Without any change in settings). Later, I followed above steps for the same problematic repo and extensions started working perfectly like before.. One important thing, I changed default formatters of Vetur that made it work perfectly. You can check above images 4,5 and 6. |
Is there any resolution ? It's seems that my vscode is awayls being blocked by this. |
It seems to be saving without the warning coming up and it doesn't seem to be corrupting the file. So it looks like it is fixed. I will keep an eye out over the next few days. Thank you very much for your work on Vetur! |
0.29.0 nothing has changed for me :( |
0.29.0 does not help with the VueServerMain getting stuck at 99% CPU, as soon as vetur activates. |
@hendrikbunnick may I ask which version works best for you? |
@sqal im using 0.25.0. |
If you can provide a repro case, we can debug it. If you don't want to make it public, you can email me directly. |
0.29.0 doesn't fix it for me as well |
0.30.0 seems to be working for me. |
0.30.2 is not working for me, still the same issues as after 0.25.0 |
|
I don't think it's a problem with Vetur but with VS Code. Getting the same popup every time I save and it's just a simple TypeScript & ESLint project. |
@MarvinRudolph there's this issue which has been open for a while as well: |
ESlint fixes were instantaneous on every files except |
Been working to fix this for 5 days now. Saving.. Getting code actions from "Vetur", "Eslint" on my monrepo takes alot of time. [Trace - 13:38:41] Received response 'textDocument/codeAction - (7)' in 276674ms. [Trace - 13:39:50] Received response 'textDocument/hover - (8)' in 340344ms. |
Wow, is it a big project? |
Just starting having this same exact problem as of Sunday. Last Friday I did not have the problem. |
Still having this problem. I tried to downgrade both Vetur and ESLint and still had the problem, but a tiny bit less. Then I decided to completely disable ESLint and remove all of its relevant settings from my settings file. The problem was just as bad. So I'm thinking this is definitely more a problem with Vetur than ESLint, because otherwise why would this error happen when ESLint is completely disabled? @octref @yoyo930021 Is anybody even looking at this problem anymore? If you want a repo where I have been having this problem, I can provide you access to it. I already have ESLint looking at the same repo to try to problem solve on their side. |
So out of frustration between constant errors, and authors of both extensions not responding to anybody (or any issues for that matter) for many weeks, I completely disabled Vetur and all of its settings were removed. I then installed other extension to get syntax highlighting and formatting. I'm still having the same problem showing up. That leads me to believe it's ESLint that's the problem, not Vetur. Perhaps Vetur has it's own problem with this as well, but I know for sure that with it turned off I still have the problem. |
I don't know if it helps, but it's indeed eslint taking a long time to process and not Vetur. After switching to TS, Airbnb and the latest depends the problem disappeared. I'm using Quasar and it seems their default present offers a good config when using Vetur as well. |
I can take a look. |
@webdevnerdstuff @francoism90 eslint is not the issue, it's either vetur or the eslint extension, because when running things from the command line instead of asking vetur to manage stuff, things go fast Here's a fix #2150 (comment) |
After updating to 0.37.2 it started happening to me too. Downgrading to 0.36.1 fixed it. |
I had the same problem, just reload the Vetur package (in the vscode extensions list) and it worked |
Among the four Nuxt v2 repositories, this problem occurred in only one. |
Info
Problem
Since I upgraded Vetur from 0.25.0 to 0.26.1, after I edit and save .vue files, vscode get stuck with this promote:
even though the change is very mirror. I have to downgrade to 0.25.0 to avoid this !
local eslint version is eslint@6.8.0
here is my vsocde setting:
Reproducible Case
The text was updated successfully, but these errors were encountered: