Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more detailed symbol info for tags with slot-related attributes #2169

Closed
1 task done
sethidden opened this issue Aug 15, 2020 · 0 comments · Fixed by #2191
Closed
1 task done

Implement more detailed symbol info for tags with slot-related attributes #2169

sethidden opened this issue Aug 15, 2020 · 0 comments · Fixed by #2191

Comments

@sethidden
Copy link
Contributor

sethidden commented Aug 15, 2020

  • I have searched through existing issues

Feature Request

  1. Show slots in vscode symbol browser:
    obraz

  2. Show slot[name="slotname"] in symbol search instead of just slot in symbol search

Things I'm not sure about:

  • Should old slot & slot-scope syntax be supported?
  • Displaying the slot like div#id.class #slotname is weird as two attrs use the # symbol (which is normally reserved for id). Maybe div#id.class[#slotname] would be better? VSCode never returns attr info for symbols in .html files though (eg. <input type='number'> still returns symbol info like input rather than input[type='number']
  • Should slot syntax be unified in symbols? eg. should symbol search always show template[#slot] even though the user explicitly wrote <template v-slot:slot> in code?

Rationale

Consider this case where you have a large component with many slots. You may want to quickly jump between slots using the symbol search (CTRL+SHIFT+O).

cereschen pushed a commit to cereschen/vetur that referenced this issue Sep 10, 2020
cereschen pushed a commit to cereschen/vetur that referenced this issue Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants