-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VTI] VTI should return exit code 1 and display more useful errors on unknown errors #2324
Closed
3 tasks done
Labels
Comments
yoyo930021
added a commit
to yoyo930021/vuter
that referenced
this issue
Sep 25, 2020
yoyo930021
added a commit
to yoyo930021/vuter
that referenced
this issue
Sep 25, 2020
Merged
yoyo930021
added a commit
to yoyo930021/vuter
that referenced
this issue
Sep 25, 2020
@yoyo930021 do you have an opinion on exiting with error code 1 (failure) when no files are found? |
No, I commit it when I rebase branch. |
yoyo930021
added a commit
to yoyo930021/vuter
that referenced
this issue
Oct 7, 2020
yoyo930021
added a commit
to yoyo930021/vuter
that referenced
this issue
Oct 7, 2020
yoyo930021
added a commit
to yoyo930021/vuter
that referenced
this issue
Oct 7, 2020
yoyo930021
added a commit
to yoyo930021/vuter
that referenced
this issue
Oct 7, 2020
octref
added a commit
that referenced
this issue
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
If VTI hits an error not already accounted for with the existing exception handlers, it just prints
VTI operation failed
with no further information. It also exits with error code 0.Proposed solution
Potential Problem
I'm less sure about this one, but also if there are no files it exits with error code 0 (success). I think ESLint does the same, but arguably it should be treated as a failure so that if, say, a CI pipeline tried to run VTI on the wrong directory with no found Vue files it should return a failure so that the mistake can be picked up.
I'm happy to fix these if the solutions are OK.
The text was updated successfully, but these errors were encountered: