Pass correct PID to language server #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyo930021
approved these changes
Mar 30, 2020
|
Is it possible to merge this PR please? This bug makes VTI pretty much unusable :( |
|
Awesome, thank you @TheBeastOfCaerbannog! 🙏 Great debugging on this |
Stanzilla
approved these changes
Jun 23, 2020
|
Sorry I have been on leave. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS Code Language Server sends
SIG_0to parent process, to make sure it's still alive. However, callingkillwithSIG_0also performs permission check, and since VTI passes 1 as processId -killfails and language server thinks the parent process doesn't exist.This PR suggests a fix to this problem by passing a real PID.
Resolves: #1699