Fix #1341 - Make sure initializationOptions is at least empty object #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulus
commented
May 7, 2020
server/src/services/vls.ts
Outdated
| @@ -83,6 +83,7 @@ export class VLS { | |||
| } | |||
|
|
|||
| async init(params: InitializeParams) { | |||
| params.initializationOptions = params.initializationOptions || {}; | |||
There was a problem hiding this comment.
Required to use VLS in Eclipse LSP4E, probably other simple implementation also. This field normally not exists.
There was a problem hiding this comment.
No longer needed since we now use ?. to access it
zulus
commented
May 7, 2020
| @@ -118,6 +118,18 @@ export function getDefaultVLSConfig(): VLSConfig { | |||
| experimental: { | |||
| templateInterpolationService: false | |||
| } | |||
| } | |||
| }, | |||
| css: {}, | |||
There was a problem hiding this comment.
VLS just forward config.emmet and others to sub-services. Even undefined, after this sass <style lang="scss"> is operational.
zulus
force-pushed
the
bug_1341
branch
3 times, most recently
from
15ea6a0 to
93b7f7f
Compare
|
No longer applies, and should already be fixed by #1705. |
|
Thank you and sorry for the delay 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change that allows me to register vls in eclipse LSP4E