-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow analyzing Vue files in node_modules
#1979
Allow analyzing Vue files in node_modules
#1979
Conversation
a66e469
to
2ecd808
Compare
+ use project files to check for Virtual files
2ecd808
to
56a2f0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Thank you and sorry for my late response.
Is there a specific reason you are making the ScriptKind.Deferred
change?
I tested and there I didn't see any problem, so I'm ok for merging it.
@octref the config returned by This was masked by the fact that the extension checked for files itself (manually ignoring |
@octref on a separate note, it may make sense to set this to an even more permissive: export function isVirtualVueFile(path: string, projectFiles: Set<string>) {
return path.endsWith('.vue.ts') &&
(!path.includes('node_modules') || projectFiles.has(path.slice(0, -'.ts'.length))); |
@tiagoroldao Do you mind sending another PR that documents this inline?
👍 , would be great if you can combine the changes into one PR. Being a bit looser is better, as many users don't propoerly setup jsconfig/tsconfig, so some Vue files might not be included in the TS project. |
Will do. |
@tiagoroldao I added your suggestion directly since I need to make a new release, and I want to get the |
Eheh, I was busy making the PR, only saw this now! Feel free to close #2112 if it is now irrelevant! |
node_modules
in path)Fixes #1127