Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when optional camel-cased props are missing #2342

Merged
merged 3 commits into from
Oct 30, 2020

Conversation

yoyo930021
Copy link
Member

@yoyo930021 yoyo930021 commented Sep 28, 2020

Fixed #2314

@yoyo930021 yoyo930021 changed the title Fix #2314 Fix error when optional camel-cased props are missing Sep 28, 2020
@yoyo930021 yoyo930021 force-pushed the fix-2314 branch 2 times, most recently from 8b60dcd to b61c1fa Compare October 7, 2020 15:24
@@ -8,7 +8,8 @@ export default Vue.extend({
callback: {
type: Function as PropType<() => void>
},
arr: Array as PropType<string[]>
arr: Array as PropType<string[]>,
darkMode: { type: Boolean, default: false }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding this here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If add this camelCase props, it success fixed when no errors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just call it camelCase so it's clear what you are testing against

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@octref octref merged commit 962b035 into vuejs:master Oct 30, 2020
@octref
Copy link
Member

octref commented Oct 30, 2020

Awesome work 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Template validation props] Error when optional camel-cased props are missing
2 participants