Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional chaining in template #2426

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Fix optional chaining in template #2426

merged 3 commits into from
Nov 2, 2020

Conversation

yoyo930021
Copy link
Member

@yoyo930021 yoyo930021 commented Nov 2, 2020 •
edited
Loading

Fixed #2423

@yoyo930021 yoyo930021 requested a review from ktsn November 2, 2020 10:29
octref
octref approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added a unit test. I'd prefer to add unit test whenever possible since they run much faster.

@octref octref merged commit b318f47 into vuejs:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octref octref octref approved these changes

@ktsn ktsn Awaiting requested review from ktsn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional Chaning does not work on template
2 participants
@yoyo930021 @octref