Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component data not shown in hover when template interpolation is on #2879

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

rchl
Copy link
Collaborator

@rchl rchl commented Apr 21, 2021

In cases where template interpolation provided some data for the hover
popup, it overrode the popup contents without letting component data
hover info to show.

Ask both services and merge the results together so that nothing is
lost.

Fixes #2878

rchl added 2 commits April 21, 2021 22:18
In cases where template interpolation provided some data for the hover
popup, it overrode the popup contents without letting component data
hover info to show.

Ask both services and merge the results together so that nothing is
lost.

Fixes vuejs#2878
Copy link
Member

@yoyo930021 yoyo930021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoyo930021 yoyo930021 merged commit 8f9e8ad into vuejs:master Apr 26, 2021
@rchl rchl deleted the fix/component-data-hover branch April 26, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component data attribute description missing for dynamic attributes
2 participants