feat(theme): allow selectively disabling external link icon on navbar items #3607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that by default, VitePress automatically adds an icon based on whether the link is an external link or not. I see that there's an option to disable external link icons entirely but that wasn't quite what I was looking for (plus couldn't get it to work). I also noticed that this option used to exist but was removed here which made sense for that use case, but this PR makes it optionally able to be removed on a "per link" level.
User Case:
This seems to work very nicely and gave the results I was looking for. I'm hoping this can be added.
Results: