Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Persian language #4089

Merged
merged 23 commits into from
Dec 13, 2024
Merged

docs: add Persian language #4089

merged 23 commits into from
Dec 13, 2024

Conversation

amir78729
Copy link
Contributor

Description

This PR adds the Persian language locale to VItePress Doc

Linked Issues

fixes #4047

Additional Context


Tip

The author of this PR can publish a preview release by commenting /publish below.

@amir78729 amir78729 changed the title Doc/add persian docs: add Persian language Aug 1, 2024
@brc-dd
Copy link
Member

brc-dd commented Aug 3, 2024

Please update lunaria.json too. And I need someone from the community to review the translations. I also need feedback on RTL UI. Let me know which things look weird and how they should look, I will adjust the styles.

@brc-dd brc-dd added docs Improvements or additions to documentation translations labels Aug 3, 2024
@userquin
Copy link
Member

userquin commented Aug 3, 2024

@brc-dd maybe this can help you (or not ;) ): https://github.com/elk-zone/elk/blob/main/CONTRIBUTING.md#rtl-support

@amir78729
Copy link
Contributor Author

amir78729 commented Aug 6, 2024

Please update lunaria.json too. And I need someone from the community to review the translations. I also need feedback on RTL UI. Let me know which things look weird and how they should look, I will adjust the styles.

@brc-dd Thanks, sure.

  • Nav: spacings between items are not correct

image

  • Hero: text-align should be right

image

  • Sidebar: it's better to put the sidebar on the right side of the page

image

  • Search input: spacings are not correct

image

  • Search modal: spacings in the footer and inside the input (the space between the icon and the text)

image

  • Change language select: when using RTL, the spacings of the Persian options are not correct:

image

@amir78729
Copy link
Contributor Author

@brc-dd Are there any updates on fixing RTL issues? Is there anything I can help with?

@brc-dd
Copy link
Member

brc-dd commented Aug 18, 2024

Ah, sorry, no. I'm bit busy recently with day job. Will try to look into by next week.

@amir78729
Copy link
Contributor Author

Ah, sorry, no. I'm bit busy recently with day job. Will try to look into by next week.

No problem. Let me know if there's anything I can help you with.

@amir78729
Copy link
Contributor Author

Any updates? @brc-dd

@brc-dd
Copy link
Member

brc-dd commented Nov 30, 2024

Sorry for the delay.

Can you check the preview again and list out the issues?

Also, the individual headings need anchors, so that switching locales can keep the position same. See https://github.com/vuejs/vitepress/blob/main/docs/ru/guide/asset-handling.md?plain=1 for example (notice things inside {...})

@amir78729
Copy link
Contributor Author

Sorry for the delay.

Can you check the preview again and list out the issues?

Also, the individual headings need anchors, so that switching locales can keep the position same. See https://github.com/vuejs/vitepress/blob/main/docs/ru/guide/asset-handling.md?plain=1 for example (notice things inside {...})

Everything looks fine.

There's another thing that I suggest changing. If the text color has opacity in languages like Persian (where the characters are connected), the overlap of characters will be bolder. Can we remove the opacity and use solid text colors to avoid the bolder overlap of characters?

image

@brc-dd
Copy link
Member

brc-dd commented Dec 9, 2024

Updated the colors. Please add the headers thing I mentioned earlier and this will be good to merge I guess 👀

@userquin
Copy link
Member

userquin commented Dec 11, 2024

external link icons shouldn't be changed with transform: rotate(-90deg)?

imagen

This should be the result:

imagen

@brc-dd
Copy link
Member

brc-dd commented Dec 11, 2024

updated

@brc-dd brc-dd merged commit a3f994b into vuejs:main Dec 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Persian Language to the Documentation
4 participants