use usePreferredDark with appearance: "force-auto"
#4263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
appearance: "force-auto"implemented in #3946 1e8bb48 has a small bug where if the user had previously set the preferred color scheme using the appearance toggle, thenuseDarkwould retain that preference from local storage rather than respecting the system color scheme. This switches tousePreferredDarkfor"force-auto", thereby ignoring whatever is (or was) in local storage and always respecting the system color scheme.Linked Issues
#3946
Additional Context
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.