Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endregion snippet extraction does not require tag #4287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnsimons
Copy link
Contributor

Description

The snippet extraction via region syntax from VSCode does not require the endregion to have a matching tag.

Here are a few examples of what is allowed:
regions

Linked Issues

Additional Context


Tip

The author of this PR can publish a preview release by commenting /publish below.

@brc-dd
Copy link
Member

brc-dd commented Oct 17, 2024

/publish

Copy link

pkg-pr-new bot commented Oct 17, 2024

npm i https://pkg.pr.new/vitepress@4287

commit: b09446e

@johnsimons
Copy link
Contributor Author

Hi @brc-dd,
Is there anything else you need me to do here?

The snippet extraction via region syntax from VSCode does not require the endregion to have a matching tag
@johnsimons
Copy link
Contributor Author

Hi @brc-dd,
Sorry to keep pinging.
I am wondering if I did not follow the process here and hence the delay in getting this merged.
Is there anything I need to complete or do differently to get this PR over the line? Any feedback so I can improve for next time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants