Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github personal access token if provided in env #369

Closed
wants to merge 2 commits into from

Conversation

znck
Copy link
Member

@znck znck commented Feb 22, 2017

This PR includes

  • Use GITHUB_PERSONAL_ACCESS_TOKEN if defined in env

Fixes #368

@posva
Copy link
Member

posva commented Feb 22, 2017

I'd actually call it GITHUB_TOKEN because I already have a variable with that name in a .tokenrc file I just source. So I think it would be better to pass an option to the cli so users can pass their tokens as they want and detect this error to point them how to use a custom token (there must be some kind of gh blog post about it)

@znck
Copy link
Member Author

znck commented Feb 22, 2017

That would be better.

So, --token would set github personal access token.

Should it load GITHUB_TOKEN from env. ( 😑 it cumbersome to add token every time vue list is called)

@zigomir
Copy link
Contributor

zigomir commented Jun 17, 2017

@znck there is not a lot api rate limit exceeded issues reported no more. But, this simple fix is probably still very valuable to people who gets it. I think we'd need to add a clear documentation on how to specify GITHUB_TOKEN to make this work; Link to GitHub Personal Access Tokens and describe every step.

What do you think?

@yyx990803
Copy link
Member

Thanks for the PR and sorry for letting it sit for so long. As of now, we are no longer adding new features of vue-cli 2.x, so I am closing this PR. Again, thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants