Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getDocumentFragment() to parserServices #38

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Add getDocumentFragment() to parserServices #38

merged 1 commit into from
Nov 9, 2019

Conversation

ota-meshi
Copy link
Member

VDocumentFragment is required even if <template> does not exist, to implement vue/component-tags-order.
vuejs/eslint-plugin-vue#763

getDocumentFragment() can get VDocumentFragment even if <template> does not exist.

mysticatea
mysticatea approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This request sounds reasonable, and LGTM.

I apologize for my late response.

@mysticatea mysticatea merged commit 075d3ff into vuejs:master Nov 9, 2019
@ota-meshi ota-meshi deleted the add-get-document branch November 9, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ota-meshi @mysticatea