v-router warning about using v-slot #3457
Labels
Comments
jonaskuske
added a commit
to jonaskuske/vue-router
that referenced
this issue
Jan 26, 2021
closes vuejs#3457 Only show deprecation warning if the props "tag" or "event" are actually passed by the consumer (key exists in propsData), not if they have any value at all (they always have a value since a default is specified in the props definition)
posva
pushed a commit
that referenced
this issue
Jan 26, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
3.5.0
Reproduction link
d2cb951#diff-d69779a774d18aab6696dcf281454982a329104177c1a5f885089da9fefefd94R134-R148
Steps to reproduce
See the conditions for firing the warning:
d2cb951#diff-d69779a774d18aab6696dcf281454982a329104177c1a5f885089da9fefefd94R134-R148
What is expected?
You should only get the warning about using v-slot if you are actually using
tagoreventpropsWhat is actually happening?
Since
tagandeventhave non-falsey default values, the warning will always fire with any use of router-link.Perhaps you should just compare if the values for
tagoreventare non-default and fire the warning, even though this doesn't cover the edge case thattagoreventare actually being passed in with a value that matches the default.The text was updated successfully, but these errors were encountered: