Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typings): adapt to the new Vue typings #1685

Merged
merged 6 commits into from
Oct 11, 2017

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Aug 15, 2017

Please do not merge this until vuejs/vue#6391 is merged

I'll update the deps in package.json when vuejs/vue#6391 is merged and released.

close #1204

BREAKING CHANGE: It is no longer compatible with the old Vue typings
package.json Outdated
"uglify-js": "^3.0.17",
"vue": "^2.3.0",
"vue": "DanielRosenwasser/vue#e4a8545",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line will change once the other PR at vuejs/vue gets merged, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, exactly!

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ktsn !

@yyx990803 yyx990803 merged commit 8855e36 into vuejs:dev Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants