Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return a promise with push and replace #2862

Merged
merged 4 commits into from
Aug 1, 2019
Merged

feat: return a promise with push and replace #2862

merged 4 commits into from
Aug 1, 2019

Conversation

Mighty683
Copy link
Contributor

Closing(#1769)

Changing behaviour of push replace to return promise when no callback is provided.

@posva posva changed the title fix: push/replace return promise close(#1769) feat: return a promise with push and replace Jul 31, 2019
types/router.d.ts Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
test/unit/specs/api.spec.js Outdated Show resolved Hide resolved
test/unit/specs/api.spec.js Outdated Show resolved Hide resolved
test/unit/specs/api.spec.js Outdated Show resolved Hide resolved
test/unit/specs/api.spec.js Outdated Show resolved Hide resolved
@posva
Copy link
Member

posva commented Jul 31, 2019

I fixed the problems with e2e tests, you can rebase against dev

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit d907a13 into vuejs:dev Aug 1, 2019
@vue-bot
Copy link

vue-bot commented Aug 1, 2019

Hey @Mighty683, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants