-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return a promise with push and replace #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
changed the title
fix: push/replace return promise close(#1769)
feat: return a promise with push and replace
Jul 31, 2019
posva
requested changes
Jul 31, 2019
I fixed the problems with e2e tests, you can rebase against dev |
posva
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hey @Mighty683, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
7 tasks
This was referenced Aug 29, 2019
This was referenced Sep 30, 2019
This was referenced Oct 26, 2019
This was referenced Jan 20, 2020
This was referenced Feb 5, 2020
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.4
michaelwybraniec/vue-vuex-jwt-authentication-example#2
Open
This was referenced Mar 4, 2020
This was referenced Mar 24, 2020
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing(#1769)
Changing behaviour of
push
replace
to return promise when no callback is provided.