Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TS): update type of Route.name #3117

Merged
merged 2 commits into from
Feb 7, 2020
Merged

fix(TS): update type of Route.name #3117

merged 2 commits into from
Feb 7, 2020

Commits on Feb 6, 2020

  1. Update type of Route.name 

    On very first load, `name` is `null`, not `string` or `undefined`. This means that either the passed route is wrong, or the type is incorrect.
    @rijkvanzanten
    rijkvanzanten authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    03e2cb6 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. fix(tests): fix type test

    @rijkvanzanten
    rijkvanzanten committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    252a368 View commit details
    Browse the repository at this point in the history