fix: add stub without modifying (#1085)

vuejs · Dec 29, 2018 · 1f4876e · 1f4876e
1 parent f35cf87
commit 1f4876e
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 14 deletions.
diff --git a/packages/create-instance/create-component-stubs.js b/packages/create-instance/create-component-stubs.js
@@ -167,13 +167,8 @@ export function createStubsFromStubsObject (
     if (componentNeedsCompiling(stub)) {
       compileTemplate(stub)
     }
-    const name = originalComponents[stubName] &&
-    originalComponents[stubName].name
 
-    acc[stubName] = {
-      name,
-      ...stub
-    }
+    acc[stubName] = stub
 
     return acc
   }, {})

diff --git a/test/specs/mounting-options/stubs.spec.js b/test/specs/mounting-options/stubs.spec.js
@@ -64,18 +64,18 @@ describeWithMountingMethods('options.stub', mountingMethod => {
     mountingMethod.name === 'renderToString',
     'replaces component with a component',
     () => {
+      const mounted = sinon.stub()
+      const Stub = {
+        template: '<div />',
+        mounted
+      }
       const wrapper = mountingMethod(ComponentWithChild, {
         stubs: {
-          ChildComponent: {
-            render: h => h('time'),
-            mounted () {
-              console.info('stubbed')
-            }
-          }
+          ChildComponent: Stub
         }
       })
-      expect(wrapper.findAll(Component).length).to.equal(1)
-      expect(info.calledWith('stubbed')).to.equal(true)
+      expect(wrapper.findAll(Stub).length).to.equal(1)
+      expect(mounted).calledOnce
     }
   )
 
@@ -567,4 +567,28 @@ describeWithMountingMethods('options.stub', mountingMethod => {
     )
     expect(HTML).to.contain('h1')
   })
+
+  itDoNotRunIf(
+    mountingMethod.name === 'renderToString',
+    'uses original component stub', () => {
+      const Stub = {
+        template: '<div />'
+      }
+      const ToStub = {
+        template: '<div />'
+      }
+      const TestComponent = {
+        template: '<div><to-stub /></div>',
+        components: {
+          ToStub
+        }
+      }
+      const wrapper = mountingMethod(TestComponent, {
+        stubs: {
+          ToStub: Stub
+        }
+      })
+      expect(wrapper.find(ToStub).exists()).to.be.false
+      expect(wrapper.find(Stub).exists()).to.be.true
+    })
 })