Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use sandbox to avoid memory leaks in test #1128

Merged
merged 7 commits into from
Feb 3, 2019

Conversation

eddyerburgh
Copy link
Member

  • Replace sinon.stub calls with sandbox.stub

sinon.stub was stopping some components being garbage collected. Using sandbox instead of sinon, and restoring after each test speeds up the test suite by 100%.

@eddyerburgh eddyerburgh merged commit 0c07653 into vuejs:dev Feb 3, 2019
@eddyerburgh eddyerburgh deleted the test-fix-memory-leak branch February 3, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant