Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #1253 setValue triggering "ReferenceError: $set is not defined" #1287

Merged
merged 2 commits into from
Aug 11, 2019
Merged

FIX #1253 setValue triggering "ReferenceError: $set is not defined" #1287

merged 2 commits into from
Aug 11, 2019

Conversation

piktur
Copy link
Contributor

@piktur piktur commented Aug 1, 2019

This PR adds assigns vm.$set reference to scoped slot helpers, avoiding ReferenceError described in #1253

eddyerburgh
eddyerburgh approved these changes Aug 11, 2019
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will be released in the next version (Early September at the latest)

@eddyerburgh eddyerburgh merged commit a9eea7b into vuejs:dev Aug 11, 2019
@vue-bot
Copy link

vue-bot commented Aug 11, 2019

Hey @piktur, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piktur @vue-bot @eddyerburgh