Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync docs with v1.0 #1538

Merged
merged 5 commits into from
May 8, 2020
Merged

Sync docs with v1.0 #1538

merged 5 commits into from
May 8, 2020

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented May 7, 2020

Closes #1536.

This PR aims to sync docs with v1.0 release.

@afontcu afontcu self-assigned this May 7, 2020
lmiller1990
lmiller1990 approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JessicaSachs
Copy link
Collaborator

Love it.

@lmiller1990 lmiller1990 merged commit 44ac570 into dev May 8, 2020
@lmiller1990 lmiller1990 deleted the docs-v1 branch May 8, 2020 05:09
@hiendv
Copy link
Contributor

hiendv commented May 25, 2020

I've been testing with find and realize that find({string} selector) would also yield an object. Hence, we should also encourage using .element when querying with selectors, not only findComponent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmiller1990 lmiller1990 lmiller1990 approved these changes

@JessicaSachs JessicaSachs JessicaSachs approved these changes

@dobromir-hristov dobromir-hristov Awaiting requested review from dobromir-hristov

Assignees

@afontcu afontcu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Marking deprecated methods in docs
4 participants
@afontcu @JessicaSachs @hiendv @lmiller1990