Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iife build #1555

Merged
merged 1 commit into from
May 22, 2020
Merged

Fix iife build #1555

merged 1 commit into from
May 22, 2020

Conversation

lmiller1990
Copy link
Member

resolves #1553 , hopefully.

@@ -2,7 +2,7 @@
import Vue from 'vue'
import semver from 'semver'
import { VUE_VERSION } from './consts'
import { config } from '@vue/test-utils'
import { config } from '../test-utils/src'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure it's ideal to import across packages but 🤷 seems to work great here.

I don't know why this project is a mono-repo.

@afontcu
Copy link
Member

afontcu commented May 22, 2020

hopefully

Is there any way to test it out?

@lmiller1990
Copy link
Member Author

lmiller1990 commented May 22, 2020

@afontcu I tested it in my browser by creating an index.html and having Vue globally available, and using the iife build - works fine.

I hope it doesn't break anything else. All tests are green... but they were before too. We probably need some way to test the iife build, but it's nothing something I can put time into right now. I guess we need to set up selenium with nightwatch, or something.

@afontcu
Copy link
Member

afontcu commented May 22, 2020

@afontcu I tested it in my browser by creating an index.html and having Vue globally available, and using the iife build - works fine.

"it works on my machine!!" 😂

joking aside, build is already broken so as long as tests are green… 👍

@lmiller1990 lmiller1990 merged commit 2858f24 into dev May 22, 2020
@lmiller1990 lmiller1990 deleted the fix-iife branch May 22, 2020 14:37
@sullivanpt
Copy link

sullivanpt commented May 22, 2020

We probably need some way to test the iife build, but it's nothing something I can put time into right now. I guess we need to set up selenium with nightwatch, or something.

Actually we don't need full blown selenium. We can test the iife in node with karma + puppeteer -- we use karma + phantomjs but I don't recommend it because it's not maintained and going stale.

Anyway, if I have free time I'll try to pull this together. (nvm. the yarn+ts+flow learning curve is a bit much for me to contribute directly. sorry)

Thanks so much for fixing the IIFE so quickly!

@lmiller1990
Copy link
Member Author

lmiller1990 commented May 22, 2020

I will release early next week @sullivanpt !

If you need it now, clone the repo, yarn install && yarn build and grab the iife build from dist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IIFE build is broken
3 participants