-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix iife build #1555
Fix iife build #1555
Conversation
@@ -2,7 +2,7 @@ | |||
import Vue from 'vue' | |||
import semver from 'semver' | |||
import { VUE_VERSION } from './consts' | |||
import { config } from '@vue/test-utils' | |||
import { config } from '../test-utils/src' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure it's ideal to import across packages but 🤷 seems to work great here.
I don't know why this project is a mono-repo.
Is there any way to test it out? |
@afontcu I tested it in my browser by creating an I hope it doesn't break anything else. All tests are green... but they were before too. We probably need some way to test the iife build, but it's nothing something I can put time into right now. I guess we need to set up selenium with nightwatch, or something. |
"it works on my machine!!" 😂 joking aside, build is already broken so as long as tests are green… 👍 |
Actually we don't need full blown selenium. We can test the iife in node with karma + puppeteer -- we use karma + phantomjs but I don't recommend it because it's not maintained and going stale.
Thanks so much for fixing the IIFE so quickly! |
I will release early next week @sullivanpt ! If you need it now, clone the repo, |
resolves #1553 , hopefully.