Wrapper array consistency #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make wrapperarray setData awaitable to be consistent with wrapper setData
Make wrapperarray setProps awaitable to be consistent with wrapper setData
Make wrapperarray setValue awaitable to be consistent with wrapper setValue
Make wrapperarray setChecked awaitable to be consistent with wrapper setChecked
Make wrapperarray trigger awaitable to be consistent with wrapper trigger
13 tasks
|
Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
wrapper-arrayandwrapperAPI's are a bit diverged. The standalonewrapperisawaitable, but thewrapper-arrayis not currently, which means other means of promise settling are needed to make sure the components are updated inwrapper-array. This PR allows for thosewrapper-arrayitems to beawaited and consistent with thewrapperAPI.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: