-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the wrapper.getComponent method and corresponding documents. #1714
Conversation
docs: create the /docs/api/wrapper/getComponent.md, and add the deprecation message to the /docs/api/wrapper/get.md docs(zh): create the /docs/zh/api/wrapper/getComponent.md, and add the deprecation message to the /docs/zh/api/wrapper/get.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just suggested a small tweak (in several files, but a single tweak after all!) that bitten us in the past :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to make the recommended changes, and I will release this. Thanks!
Co-authored-by: Adrià Fontcuberta <afontcu@gmail.com>
Co-authored-by: Adrià Fontcuberta <afontcu@gmail.com>
Co-authored-by: Adrià Fontcuberta <afontcu@gmail.com>
Co-authored-by: Adrià Fontcuberta <afontcu@gmail.com>
Co-authored-by: Adrià Fontcuberta <afontcu@gmail.com>
Closes #1711
feat: add the wrapper.getComponent method
docs: create the /docs/api/wrapper/getComponent.md, and add the deprecation message to the /docs/api/wrapper/get.md
docs(zh): create the /docs/zh/api/wrapper/getComponent.md, and add the deprecation message to the /docs/zh/api/wrapper/get.md