fix #1813 #1817
Merged
fix #1813 #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djaler
force-pushed
the
fix/find-functional-component
branch
from
9d18161 to
96a6498
Compare
lmiller1990
requested changes
Apr 7, 2021
| const componentInstance = isFunctionalSelector | ||
| ? node[FUNCTIONAL_OPTIONS] | ||
| : node.child | ||
| const componentInstance = node[FUNCTIONAL_OPTIONS] || node.child |
There was a problem hiding this comment.
Looks like the line you removed was for back compat. You might need to skip the failing test. Are you able to update the PR and fix the failing test?
There was a problem hiding this comment.
Should I just skip this test for vue < 2.3?
There was a problem hiding this comment.
Because I find no way to throw exception in this case
There was a problem hiding this comment.
Sure, that's probably fine, go for it. I think most people will be on at least 2.5 by now.
|
Thanks for this! |
Djaler
force-pushed
the
fix/find-functional-component
branch
2 times, most recently
from
c3db9b2 to
784211a
Compare
Djaler
force-pushed
the
fix/find-functional-component
branch
from
784211a to
ba86ef3
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)