Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly find functional components #1835

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Conversation

lmiller1990
Copy link
Member

@lmiller1990 lmiller1990 commented Apr 30, 2021

Attempting to fix #1820, grabbed some work from https://github.com/vuejs/vue-test-utils/pull/1832/files and some additional code from the original issue. This seems to satisfy all the test cases.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lmiller1990 lmiller1990 mentioned this pull request Apr 30, 2021
@Bastczuak
Copy link

@lmiller1990 looks superb dude! but why is this specific test, I also had my problems with, failing in test:compat but not in test:unit:browser? Where is the difference?

@lmiller1990
Copy link
Member Author

@Bastczuak test-compat will run the suite against all the older versions of Vue, lik v2.1, v2.2, v2.3... I have no idea why that router tests fails on versions v2.5 and older, I guess some internals changed. The matching logic goes super deep into various undocumented internals.

v2.6 is over two years old, we can probably afford to drop support for some of those edge cases. I'd like for some people to run this against their production code bases to see if I've broken anything else, I am not working full-time with Vue at the moment and don't have any huge production tes suites to run this against.

@lmiller1990 lmiller1990 marked this pull request as ready for review April 30, 2021 08:06
@lmiller1990 lmiller1990 merged commit c14d6fd into dev Apr 30, 2021
@lmiller1990 lmiller1990 deleted the lmiller1990/issue-1820 branch April 30, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.1.4 regression
2 participants