feat: make isVisible more comprehensive (backport from v2) (fix #1456) #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for vue-test-utils-v1 failed.
|
This was referenced Sep 30, 2022
|
@lmiller1990, just making sure this is still on your radar |
lmiller1990
reviewed
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement to isVisible to take all styling into account. This is a backport of vuejs/test-utils#454.
One notable change between this and the version in v2 is that it only works on elements that are part of the DOM (part of an attached tree). This is due to getComputedStyle being defined as only working in that scenario, per https://lists.w3.org/Archives/Public/www-style/2018May/0031.html. Chrome and Safari match the spec, but other browsers (including jsdom) allow it to still work. v2 only runs under jsdom while v1 can run under Chrome, which is why I had to narrow it here to only work when the element is part of the DOM. I imagine someday jsdom will implement that behavior as well, in which case v2+ will need to function this way as well.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
CC @lmiller1990