Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigation key names #2046

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Conversation

AlexDubok
Copy link
Contributor

@AlexDubok AlexDubok commented Jan 9, 2023

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes (but a small one) :)
  • [] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
When using keyboard events (keyup, keydown), the key event param is passed incorrectly for navigation keys. it should be ArrowRight instead of just Right according to the same document that is referred in the code: https://github.com/ashubham/w3c-keys/blob/48d9dc98a6468447bc15db8d4b15ce19ce157869/index.ts#L17

Left, Right, Up and Down were used in Internet Explorer, Edge (16 and earlier), and Firefox (36 and earlier) according to MDN. Those browsers are so old that they are deprecated.

@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for vue-test-utils-v1 failed.

Name Link
🔨 Latest commit 4ee42fd
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-v1/deploys/63bc8a619fd85b00084f47a7

Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can add a test for this? Thanks!

@AlexDubok
Copy link
Contributor Author

Any chance you can add a test for this? Thanks!

Sorry, but there is test already. I just updated expected values according to the common spec.

@lmiller1990 lmiller1990 merged commit 894abd1 into vuejs:dev Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants