Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add lint cache #2052

Merged
merged 3 commits into from
Feb 8, 2023
Merged

chore: add lint cache #2052

merged 3 commits into from
Feb 8, 2023

Conversation

Simon-He95
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@netlify
Copy link

netlify bot commented Jan 27, 2023

Deploy Preview for vue-test-utils-v1 ready!

Name Link
🔨 Latest commit e9f3795
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-v1/deploys/63e31394fe1ea500087bbcb2
😎 Deploy Preview https://deploy-preview-2052--vue-test-utils-v1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lmiller1990
Copy link
Member

I don't understand the purpose of this PR - should it have changed 70 files?

@Simon-He95
Copy link
Contributor Author

I upgraded the version of prettier so that he has the caching function, but the rules have changed a little.
I did not find that there is a property configured to be the same as before.

image

@lmiller1990
Copy link
Member

Hm, I guess we can do this.

Can you revert the changes to the files in the dist directories? We only update those when we do a release. We probably shouldn't commit these at all, but that's how the project has historically been configured.

@Simon-He95
Copy link
Contributor Author

I have reverted dist and set .eslintignore /dist/

@lmiller1990 lmiller1990 merged commit be11db6 into vuejs:dev Feb 8, 2023
@lmiller1990
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants