Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(runtime-vapor): setup() returning object is only needed in __DEV__ (HMR) #296

Merged

Conversation

LittleSound
Copy link
Member

@LittleSound LittleSound commented Nov 29, 2024

Skip the type check for production since this is only for Dev HMR

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit dc39fb4
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/674ada2d98f6e800089fb225
😎 Deploy Preview https://deploy-preview-296--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit dc39fb4
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/674ada2d54264f0008d16cfb
😎 Deploy Preview https://deploy-preview-296--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LittleSound LittleSound mentioned this pull request Nov 29, 2024
19 tasks
Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81 kB 28.4 kB 25.1 kB
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
runtime-vapor.global.prod.js 47.7 kB (-159 B) 18 kB (-59 B) 16.5 kB (-54 B)
vue-vapor.global.prod.js 47.6 kB (-159 B) 18 kB (-62 B) 16.5 kB (-54 B)
vue.global.prod.js 158 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.4 kB 18.4 kB 16.8 kB
createApp 55.5 kB 21.4 kB 19.5 kB
createVaporApp 26.9 kB (-437 B) 10.3 kB (-164 B) 9.46 kB (-137 B)
createSSRApp 59.5 kB 23.1 kB 21 kB
defineCustomElement 60.3 kB 23 kB 20.9 kB
overall 69.3 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Nov 30, 2024

Open in Stackblitzplayground

@vue/compiler-core

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-core@296

@vue/compiler-dom

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-dom@296

@vue/compiler-ssr

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-ssr@296

@vue/compiler-vapor

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-vapor@296

@vue/compiler-sfc

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-sfc@296

@vue/reactivity

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/reactivity@296

@vue/runtime-core

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-core@296

@vue/runtime-dom

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-dom@296

@vue/runtime-shared

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-shared@296

@vue/runtime-vapor

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-vapor@296

@vue/server-renderer

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/server-renderer@296

@vue/shared

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/shared@296

vue

npm i https://pkg.pr.new/vuejs/vue-vapor/vue@296

@vue/compat

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compat@296

@vue/vapor

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/vapor@296

commit: dc39fb4

@LittleSound LittleSound merged commit f0361ba into main Nov 30, 2024
11 checks passed
@LittleSound LittleSound deleted the perf/setup-returning-object-is-only-needed-in-dev-hmr branch November 30, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants