Skip to content

Commit

Permalink
fix(scheduler): getNow detection can randomly fail (#9667)
Browse files Browse the repository at this point in the history
The previous detection code compared time stamps based on Date.now()
which are not monotonic, so the check could fail due to clock skew or
adjustments.

This fix changes the check to compare against performance.now() if it is
supported, because it is monotonic (strictly increasing).
  • Loading branch information
felixbuenemann authored and yyx990803 committed Mar 11, 2019
1 parent 781c705 commit ef2a380
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/core/observer/scheduler.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ if (
inBrowser &&
window.performance &&
typeof performance.now === 'function' &&
getNow() > document.createEvent('Event').timeStamp
document.createEvent('Event').timeStamp <= performance.now()
) {
// if the event timestamp is bigger than the hi-res timestamp
// (which is evaluated AFTER) it means the event is using a lo-res timestamp,
Expand Down

0 comments on commit ef2a380

Please sign in to comment.