-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #8721,#9873: wrong type when computed return about this #11235
base: dev
Are you sure you want to change the base?
fix #8721,#9873: wrong type when computed return about this #11235
Conversation
@ktsn I don't know this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@ktsn, aren't you going to merge this bugfix? You approved it in April but it's still not merged. This one affects Vetur and breaks intelisense so it seems quite important to me as VSCode + Vetur + Vue programmer. |
Good evening, I'm wondering if someone forgot to merge this pull request, agree with @Yahohoo the intelisense is important for us, hoping someone merge it @ktsn or @yoyo930021 |
bump, @ktsn can you merge it? |
This does not seem to fix vuejs/vetur#1707 |
|
@yoyo930021 Great, now we have TS 4.0.2 in Vetur by default as well. Are you planning to send a new PR to vue? |
The problem is only work when typescript 3.9 up. |
Updating |
I guess #11488 also can fix this problem. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Fix vuejs/vetur#1707, vuejs/vetur#1509, #8721, #9873
When
computed
return aboutthis
property,The
this
type is wrong.