Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): condenses staticClass whitespace (fix #12113) #12195

Merged

Conversation

royeden
Copy link
Contributor

@royeden royeden commented Jul 25, 2021

Template "static" classes used to preserve whitespace after compilation, resulting in builds that had bigger file outputs with whitespace in component's staticClass attributes, as specified in #12113 and this issue as well.

fix #12113

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Template static classes used to preserve whitespace after compilation, resulting in builds that had
bigger file outputs with whitespace in component's staticClass attributes

fix vuejs#12113
… purged in static classes

There's no need to escape newlines in static classes, as they're now replaced with a single
whitespace character

fix vuejs#12113
@posva posva changed the title feat(compiler): template staticClass no longer preserves whitespace (fix #12113) feat(compiler): condenses staticClass whitespace (fix #12113) Sep 8, 2021
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

test/unit/features/directives/class.spec.js Outdated Show resolved Hide resolved
test/unit/features/directives/class.spec.js Outdated Show resolved Hide resolved
src/platforms/web/compiler/modules/class.js Outdated Show resolved Hide resolved
@posva posva merged commit 515467a into vuejs:dev Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiled template classes preserve whitespace
2 participants