Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): add semicolon after defineProps statement #12879

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

liulinboyi
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@sxzz
Copy link
Member

sxzz commented Nov 18, 2022

Please refer to the original PR in the repo of Vue 3.

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the snapshots to fix CI issues.

@liulinboyi
Copy link
Member Author

Please refer to the original PR in the repo of Vue 3.

ok, thanks!

@liulinboyi
Copy link
Member Author

Please update the snapshots to fix CI issues.

ok, no problem!

@sxzz
Copy link
Member

sxzz commented Nov 18, 2022

ref: vuejs/core#6461

@liulinboyi
Copy link
Member Author

ref: vuejs/core#6461

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants