Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add browser ESM 'minified build' using babel-minify #8683

Closed
wants to merge 2 commits into from
Closed

feat: add browser ESM 'minified build' using babel-minify #8683

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 21, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva
Copy link
Member

posva commented Aug 21, 2018

Did you see #7110?

@ghost
Copy link
Author

ghost commented Aug 21, 2018

@posva Yes. But @yyx990803 did not provide minified build. This pr is against branch 'esm-browser'. The minified ESM fulfills @simonhaenisch's request in #7110

@ghost ghost changed the title feat: add browser ESM minified build using babel-minify feat: add browser ESM 'minified build' using babel-minify Aug 21, 2018
@yyx990803
Copy link
Member

Thanks for the PR, however I think we should just use terser which can work on both ES5 and ES2015 builds. I'll improve #7110 to include a minified build.

@yyx990803 yyx990803 closed this Oct 23, 2018
@ghost ghost deleted the esm-browser branch October 26, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants