This repository has been archived by the owner on Dec 26, 2018. It is now read-only.
Load configuration from vue.config.js #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. 1h of testing with the config file, started adding unexpected tokens to see if anything was loaded at all. This fixes the problem! |
|
Are there any problems with this PR. I see it's not merged yet. Will hack in node_modules for now |
|
I hate doing this, but it seems it's needed to get eyes on this PR. cc/ @yyx990803 Could you please review this? Thanks, and I love the work you've done with vue 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #116 and #145
It appears
vue.config.jssimply wasn't getting loaded. This fixes it.