fix($core): regression of introducing dynamic routerBase (close: #1498)

Also renaming __VUEPRESS_ROUTE_BASE__ to __VUEPRESS_ROUTER_BASE__
vuejs · Mar 31, 2019 · 5e12b49 · 5e12b49
1 parent cb84c5c
commit 5e12b49
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/@vuepress/core/lib/client/app.js b/packages/@vuepress/core/lib/client/app.js
@@ -61,8 +61,12 @@ Vue.prototype.$withBase = function (path) {
 }
 
 export function createApp (isServer) {
+  const routerBase = typeof window !== 'undefined'
+    ? window.__VUEPRESS_ROUTER_BASE__
+    : (siteData.routerBase || siteData.base)
+
   const router = new Router({
-    base: window.__VUEPRESS_ROUTE_BASE__ || siteData.base,
+    base: routerBase,
     mode: 'history',
     fallback: false,
     routes,