feat($theme-default): support nav config for attr of internal links

vuejs · Oct 11, 2019 · 9eee190 · 9eee190
1 parent e8f91f8
commit 9eee190
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/packages/@vuepress/theme-default/components/NavLink.vue b/packages/@vuepress/theme-default/components/NavLink.vue
@@ -3,7 +3,7 @@
     class="nav-link"
     :to="link"
     @focusout.native="focusoutAction"
-    v-if="!isExternal(link)"
+    v-if="isInternal"
     :exact="exact"
   >{{ item.text }}</router-link>
   <a
@@ -42,22 +42,25 @@ export default {
     },
 
     target () {
-      return isMailto(this.link) || isTel(this.link) ? null : this.item.target || '_blank'
+      return isMailto(this.link) || isTel(this.link) ? null : this.item.target
+      || (isExternal(this.link) ? '_blank' : '')
     },
 
     isTargetBlank () {
       return this.target === '_blank'
     },
 
     rel () {
-      return isMailto(this.link) || isTel(this.link) ? null : this.item.rel || 'noopener noreferrer'
+      return isMailto(this.link) || isTel(this.link) ? null : this.item.rel
+      || (this.isTargetBlank ? 'noopener noreferrer' : '')
+    },
+
+    isInternal () {
+      return !isExternal(this.link) && !this.isTargetBlank
     }
   },
 
   methods: {
-    isExternal,
-    isMailto,
-    isTel,
     focusoutAction () {
       this.$emit('focusout')
     }

diff --git a/packages/docs/docs/theme/default-theme-config.md b/packages/docs/docs/theme/default-theme-config.md
@@ -62,6 +62,7 @@ module.exports = {
   themeConfig: {
     nav: [
       { text: 'External', link: 'https://google.com', target:'_self', rel:'' },
+      { text: 'Guide', link: '/guide/', target:'_blank' }
     ]
   }
 }

diff --git a/packages/docs/docs/zh/theme/default-theme-config.md b/packages/docs/docs/zh/theme/default-theme-config.md
@@ -59,6 +59,7 @@ module.exports = {
   themeConfig: {
     nav: [
       { text: 'External', link: 'https://google.com', target:'_self', rel:'' },
+      { text: 'Guide', link: '/guide/', target:'_blank' }
     ]
   }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -62,6 +62,7 @@ module.exports = { @@
       themeConfig: {
         nav: [
           { text: 'External', link: 'https://google.com', target:'_self', rel:'' },
+          { text: 'Guide', link: '/guide/', target:'_blank' }
         ]
       }
     }
@@ Expand Down @@