Overriding global meta description

[jaylinski]

If I define a meta-description (frontmatter) in a page, it does not seem to override the meta-description defined in .vuepress/config.js

.vuepress/config.js

module.exports = {
  title: 'vuepress is awesome',
  description: 'this should be the default description for pages that do not define their own meta descriptions',
};

Example page

---
meta:
  - name: description
    content: my custom meta description
---

I would expect that my custom meta description is rendered, but the default description from .vuepress/config.js and the frontmatter-description are rendered.

These are the code parts that seem to be responsible for the page-meta processing:

vuepress/lib/prepare.js

Line 76 in 1bbfa43

'meta', { name: 'description', content: siteConfig.description }

vuepress/lib/build.js

Line 131 in 1bbfa43

const pageMeta = renderPageMeta(page.frontmatter && page.frontmatter.meta)

vuepress/lib/build.js

Line 153 in 1bbfa43

function renderPageMeta (meta) {

I'm not sure how to tackle this issue... maybe we could inject the global description into the page.frontmatter.meta object instead of the siteConfig.head object? Something like this:

// lib/prepare.js
const frontmatter = yaml.loadFront(content)
if (siteConfig.description && !frontmatter.meta.description) {
    frontmatter.meta.description = siteConfig.description
}

[ulivz]

In fact, at current build flow, the description will be gennerated twice:

I also realized this problem, and description meta tag has been handled at #48,

I thought I'd open a PR to fix it alone, but because the multiple language support would also change it for different locale, I just added a patch(961cf2d) and fixed your problem quickly.

[yyx990803]

After @ulivz's fix the generated static files should all have correct meta. Currently during dev or after a dynamic navigation it will still have duplicated description, but for SEO purposes that probably doesn't matter.

[yyx990803]

Closed via #48

[jaylinski]

Thanks for your awesome support! ❤️

[awulkan]

It seems that this bug is still there. I get the global and the page-specific decription on my pages. This is very bad for SEO. 🙁

<meta name="description" content="From global">
<meta name="description" content="From page">

[ulivz]

@awulkan Please create an issue with the correct reproduction link 🙂

[awulkan]

@ulivz I've created one here now: #565