-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat($theme-default): support configuring target and rel for nav links (close #1353) #1734
feat($theme-default): support configuring target and rel for nav links (close #1353) #1734
Conversation
Hello @newsbielt703 thank's for the PR ! I am waiting for others approval and we will merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @newsbielt703,
If a link is considered as an internal link, adding `target: '_blank' is not working.
For example, in the official VP documentation in .vuepress/nav/en.js
:
{
text: 'Guide',
link: '/guide/',
target: '_blank',
}
This will not make the guide page open in a new tab.
389c576
to
377da36
Compare
377da36
to
9eee190
Compare
@kefranabg Thanks for your suggestion. |
Hey @newsbielt703, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
fix #1353
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: