Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($theme-default): support configuring target and rel for nav links (close #1353) #1734

Merged

Conversation

billyyyyy3320
Copy link
Collaborator

fix #1353

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@flozero
Copy link
Collaborator

flozero commented Sep 5, 2019

Hello @newsbielt703 thank's for the PR ! I am waiting for others approval and we will merge it

@flozero flozero added the status: community assigned Community assigned label Sep 5, 2019
@flozero flozero added topic: config Relates to VuePress config topic: docs Used when working with docs topic: theme Relates to VuePress theme type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress labels Sep 5, 2019
Copy link
Collaborator

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @newsbielt703,

If a link is considered as an internal link, adding `target: '_blank' is not working.

For example, in the official VP documentation in .vuepress/nav/en.js :

{
    text: 'Guide',
    link: '/guide/',
    target: '_blank',
  }

This will not make the guide page open in a new tab.

@billyyyyy3320 billyyyyy3320 force-pushed the feat/default_theme_external_link branch from 389c576 to 377da36 Compare October 11, 2019 03:52
@billyyyyy3320 billyyyyy3320 force-pushed the feat/default_theme_external_link branch from 377da36 to 9eee190 Compare October 11, 2019 03:56
@billyyyyy3320 billyyyyy3320 changed the title fix #1353 Support nav config for attr of external links feat($theme-default): support configuring target and rel for nav links Oct 11, 2019
@billyyyyy3320
Copy link
Collaborator Author

@kefranabg Thanks for your suggestion.

@ulivz ulivz self-requested a review October 11, 2019 21:25
@billyyyyy3320 billyyyyy3320 changed the title feat($theme-default): support configuring target and rel for nav links feat($theme-default): support configuring target and rel for nav links(close #1353) Oct 12, 2019
@billyyyyy3320 billyyyyy3320 changed the title feat($theme-default): support configuring target and rel for nav links(close #1353) feat($theme-default): support configuring target and rel for nav links (close #1353) Oct 12, 2019
@kefranabg kefranabg merged commit 770ba72 into vuejs:master Oct 16, 2019
@vue-bot
Copy link

vue-bot commented Oct 16, 2019

Hey @newsbielt703, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: community assigned Community assigned topic: config Relates to VuePress config topic: docs Used when working with docs topic: theme Relates to VuePress theme type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow NavLinks to open in the same window (applies to default theme)
5 participants