Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New canonicalUrl frontmatter property is incorrectly mapped in ClientComputedMixin.js #2665

Closed
1 task done
adamdehaven opened this issue Oct 15, 2020 · 2 comments
Closed
1 task done

New canonicalUrl frontmatter property is incorrectly mapped in ClientComputedMixin.js #2665

adamdehaven opened this issue Oct 15, 2020 · 2 comments

Comments

@adamdehaven
Copy link
Contributor

  • I confirm that this is an issue rather than a question.

Bug report

Steps to reproduce

What is expected?

Canonical Url is grabbed from the canonicalUrl entry in the frontmatter

What is actually happening?

The canonical URL is not being injected into the SSR template because in PR #2658 the frontmatter entry was renamed (during development) to canonicalUrl from canonical.

Line 69 in packages/@vuepress/core/lib/node/ClientComputedMixin.js is looking for a non-existent property called canonical and needs to be updated to the following:

const { canonicalUrl } = this.$page.frontmatter

Tagging @d-pollard
@d-pollard
Copy link
Collaborator

Would you want to submit a PR for this? @adamdehaven

adamdehaven added a commit to adamdehaven/vuepress that referenced this issue Oct 15, 2020
@adamdehaven
Fixes vuejs#2665 by referencing correct canonicalUrl frontmatter prop…
054ca8e 
…erty.
@adamdehaven
Copy link
Contributor Author

@d-pollard submitted PR #2666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamdehaven @d-pollard