We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
description
yarn dev
yarn build
I have a reproduction available here: https://github.com/sangeeth96/bug-vuepress-meta-description-repro
Meta tag contents are escaped before being added to HTML.
Meta tag contents aren't being escaped resulting in broken HTML.
npx vuepress info
Environment Info: System: OS: macOS 11.2.3 CPU: (8) x64 Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz Binaries: Node: 14.16.1 - ~/.nvm/versions/node/v14.16.1/bin/node Yarn: 1.22.10 - /usr/local/bin/yarn npm: 6.14.12 - ~/.nvm/versions/node/v14.16.1/bin/npm Browsers: Chrome: 90.0.4430.72 Edge: Not Found Firefox: Not Found Safari: 14.0.3 npmPackages: @vuepress/core: 1.8.2 @vuepress/theme-default: 1.8.2 vuepress: ^1.3.1 => 1.8.2 npmGlobalPackages: vuepress: Not Found
The text was updated successfully, but these errors were encountered:
fix($core): escape meta tags correctly (fix vuejs#2831)
6b3012f
Fixes vuejs#2831
I've got a PR to fix this #2832 (if this is all valid). Wasn't sure how to add test for this but I can try if someone could give me a hint.
Sorry, something went wrong.
fix: workaround for vuejs/vuepress#2831
8291656
meetup31: add musthaq (#102)
74122a9
* meetup31: add musthaq * fix: workaround for vuejs/vuepress#2831
fix($core): escape meta tags correctly (fix #2831) (#2832)
b877b3b
Fixes #2831
Successfully merging a pull request may close this issue.
Bug report
Steps to reproduce
description
set to some HTML in a markdown fileyarn dev
, notice no issuesyarn build
and open the HTML page, notice broken HTMLI have a reproduction available here: https://github.com/sangeeth96/bug-vuepress-meta-description-repro
What is expected?
Meta tag contents are escaped before being added to HTML.
What is actually happening?
Meta tag contents aren't being escaped resulting in broken HTML.
Other relevant information
npx vuepress info
in my VuePress project:The text was updated successfully, but these errors were encountered: