refactor($core): inject root mixins to root component and make LayoutDistributor functional #1231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The
clientRootMixin
should be ssr compatible.In fact, developers should always be aware of that in Vuepress, but our current
updateMeta.js
of core andmixin.js
of docs are not so good at that.So this is not an exact "breaking change".
Other information:
Based on #1228.
<Root>
component, so they are "real" root mixins now.LayoutDistributor
functional. It would be lighter-weighted, and the structure of Vuepress App invue-devtool
would be much clearer.Maybe we could have further discussion about this implementation @ulivz