-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix($plugin-pagination): get posts calculation error #1466
Conversation
I will have a look of this pr. Maybe is more about the end calculation @lhz960904 ? |
@lhz960904 can you provide me a repo example please to validate a push the merge conflict resolve |
#1345 relation with that pr too |
|
just git pull origin master and resolve from here |
This pagination plugin has been deprecated and merged into blog plugin, you can move this pull request to here. |
Summary
This plugin enhanceAppFile calculation errors to get posts. When Max is 20 interval 10, it will slice [0, 11], [10, 21] ,but the right result should be [0, 10] [10, 20]
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: